New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ignored URL handling #803

Merged

tombui99 merged 3 commits into staging from ignore-fix

Nov 29, 2023

Member

zacharykeeping commented Nov 29, 2023

Updates the ignored URL handling to also check against source URLs in addition to destination URLs, which allows us for example to ignore "/people" and "/rules" links on our home website.
Prevents uploading the full whitelisted URL list to our Scan data as large amounts of data causes this to error and we're not using this list anyway.
Fixes an issue where the wrong source URL is uploaded in the Ignore modal.


          Fix whitelisted URLs count and update ignore URL

eb58fb6

binding

zacharykeeping requested a review from tombui99

November 29, 2023 06:30

zacharykeeping added 2 commits

November 30, 2023 09:03


          Update frontend display

cc3ee6b


          Filter on scanUrl

0181a14

tombui99 approved these changes

View reviewed changes

Contributor

tombui99 left a comment

LGTM!

tombui99 merged commit 643db21 into staging

1 check passed

tombui99 deleted the ignore-fix branch

November 29, 2023 23:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet